Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-11527][Agent] Save both row and byte position information when saving offset #11528

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

justinwwhuang
Copy link
Contributor

@justinwwhuang justinwwhuang commented Nov 21, 2024

Fixes #11527

Motivation

The large amount of IO required to restore historical collection sites after Agent restart results in slow startup and requires optimization

Modifications

1 Save both row and byte position information when saving offset
2 When restarting and restoring, the byte position is directly obtained from the offset information, without the need to traverse files to calculate the position

Verifying this change

(Please pick either of the following options)

  • This change is a trivial rework/code cleanup without any test coverage.

  • This change is already covered by existing tests, such as:
    (please describe tests)

  • This change added tests and can be verified as follows:

    (example:)

    • Added integration tests for end-to-end deployment with large payloads (10MB)
    • Extended integration test for recovery after broker failure

Documentation

No doc needed

@justinwwhuang justinwwhuang self-assigned this Nov 21, 2024
@justinwwhuang justinwwhuang added this to the 2.1.0 milestone Nov 21, 2024
@justinwwhuang justinwwhuang merged commit 4f533e0 into apache:master Nov 21, 2024
10 checks passed
@justinwwhuang justinwwhuang deleted the b11527 branch November 29, 2024 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improve][Agent] Save both row and byte position information when saving offset
3 participants